search

Informatievlaanderen / VSDS-LDES-E2E-testing

End-to-end tests and tooling needed for testing LDES components build as part of VSDS
European Union Public License 1.2
5 stars 3 forks source link

ldes-client-persistence is not working properly: https://github.com/Informatievlaanderen/VSDS-LDES-E2E-testing/tree/main/e2e-test/demos/ldes-client-persistence #161

Closed xdxxxdx closed 1 year ago

xdxxxdx commented 1 year ago

Hello,

I notice the following issue in sprint 19:

Prerequisite:

Scenario:

Current result: the root fragment ("http://ldes-server-simulator/api/v1/ldes/mobility-hindrances?generatedAtTime=2022-04-19T12:12:49.47Z) image has been requested more than 1 time

Expected result: No matter where in the LDES you halted the NiFi processor, none of the requested fragments should have a count higher than 1.

Investigation

If I set as described in : https://github.com/Informatievlaanderen/VSDS-LDES-E2E-testing/tree/main/e2e-test/demos/ldes-client-persistence

the LdesClient component property Datasource url should be http://ldes-server-simulator/api/v1/ldes/mobility-hindrances

From my idea, to request all the LDES stream, the follow alias needs to be created:

{ "original": "http://ldes-server-simulator/api/v1/ldes/mobility-hindrances?generatedAtTime=2022-04-19T12:12:49.47Z", "alias": "http://ldes-server-simulator/api/v1/ldes/mobility-hindrances" }

With bash command curl -X POST http://localhost:9011/alias -H "Content-Type: application/json" -d '@create-alias.json'

In this situation. the root fragment (http://localhost:9011/api/v1/ldes/mobility-hindrances?generatedAtTime=2022-04-19T12:12:49.47Z) also been requested more than 1 time.

Please feel free to correct me If I am wrong Thanks Best regards XD

rorlic commented 1 year ago

This test has been changed to use the LDIO workbench instead of a NiFi workbench. We will review and update the documentation. However, the LDES client was fixed this sprint to request fragments only once. Because of redirects (HTTP 302) and because the LDES client needs to determine which view to follow, the first URL (typically the LDES) may be queried twice. We will update the documentation to include this information.

rorlic commented 1 year ago

FYI: the test has been renamed and can now be found at: https://github.com/Informatievlaanderen/VSDS-LDES-E2E-testing/tree/main/demos/020.client-pause-and-resume

xdxxxdx commented 1 year ago

Hello @rorlic,

Thanks for the E2E test, a small notice that: docker stop/start ldio-workflow, I think it should be docker start/stop persisted-state_ldio-workflow. image The alias link is also not working

There is a runner failure of the ldes client. To not mix up the situation, the issue is entered by case: https://github.com/Informatievlaanderen/VSDS-Linked-Data-Interactions/issues/152

Thanks

xdxxxdx commented 1 year ago

Wait for the fix of: https://github.com/Informatievlaanderen/VSDS-Linked-Data-Interactions/issues/175 https://github.com/Informatievlaanderen/VSDS-Linked-Data-Interactions/issues/152 To revalidate current case.

xdxxxdx commented 1 year ago

Validated on ghcr.io/informatievlaanderen/ldi-orchestrator:20230508T085639 with E2E tag: https://github.com/Informatievlaanderen/VSDS-LDES-E2E-testing/commit/937e069594828f84154032ebb05485323626b813