search

Informatievlaanderen / VSDS-LDES-E2E-testing

End-to-end tests and tooling needed for testing LDES components build as part of VSDS
European Union Public License 1.2
5 stars 2 forks source link

Update the cypress automation testing feature to use new docker images of LDES NIFI (ldi-workbench-nifi) #209

Closed xdxxxdx closed 1 year ago

xdxxxdx commented 1 year ago

Hello Team,

The Github commit: VSDS_LDES_E2E_testing: 6d61fc7d64a900963316aea1f099938a5c45726f

I see the automation testing which is still using the older docker image LDES-workbench-nifi image As the repositories are modified. I think for caching the changes, the automation test features also needs to be modified to use: Which needs to be modified to: ldi-workbench-nifi

Thanks XD

rorlic commented 1 year ago

All tests have been changed to use LDIO as the preferred workbench.

Some tests explicitly need to use a NiFi workbench. For these, we now use the ldi-workbench-nifi.

Some (upgrade) tests still require the old ldes-workbench-nifi image. Obviously, we have not changed these.

xdxxxdx commented 1 year ago

Will retest the case once get the new tags and close it accordingly

xdxxxdx commented 1 year ago

Hello @rorlic ,

Please have look at: https://github.com/Informatievlaanderen/VSDS-LDES-E2E-testing/tree/main/tests/012.server-provide-basic-retention. The readme is still pointing to use NIFI solution. But no json workflow provided.

Thanks

rorlic commented 1 year ago

Hi, nice catch, thanks! I see some additional issues (missing image, use of mongo compass, etc.) Will fix asap.

rorlic commented 1 year ago

Fixed. Please verify and close ticket.

xdxxxdx commented 1 year ago

Hello @rorlic @RubenHuybrighs ,

A small notice, all the ports in this doc: https://github.com/Informatievlaanderen/VSDS-LDES-E2E-testing/blob/main/demos/024.nifi-workbench-materialize-to-rdf4j/README.md for NIFI workbench are pointing to 8443. According to the docker compose it should be 8000.

Please also update the url used in https://github.com/Informatievlaanderen/VSDS-LDES-E2E-testing/tree/main/demos/023.nifi-workbench-upgrade. curl http://localhost:8080/devices-by-time is not a valid one (Not changed for sprint 26)

Thanks

xdxxxdx commented 1 year ago

Hello @rorlic ,

Please also update the url used in https://github.com/Informatievlaanderen/VSDS-LDES-E2E-testing/tree/main/demos/023.nifi-workbench-upgrade. curl http://localhost:8080/devices-by-time is not a valid one (Not changed for sprint 26)**

Thanks

xdxxxdx commented 1 year ago

Validated on 4dc8f268f213f8374131efe3388288ca1097f9a5