Informatievlaanderen / VSDS-LDESServer4J

Linked Data Event Streams Server for Java
https://informatievlaanderen.github.io/VSDS-LDESServer4J
European Union Public License 1.2
10 stars 9 forks source link

Doc: how to run: service "ldes-server" depends on undefined service ldes-postgres: invalid compose project #1300

Closed xdxxxdx closed 3 months ago

xdxxxdx commented 4 months ago

Follow the configuration documented at: https://informatievlaanderen.github.io/VSDS-LDESServer4J/how-to-run.html#docker-compose

services:
  ldes-server:
    container_name: basic_ldes-server
    image: ldes/ldes-server
    environment:
      - SPRING_CONFIG_LOCATION=/config/
    volumes:
      - ./ldes-server.yml:/config/application.yml:ro
    ports:
      - 8080:8080
    networks:
      - ldes
    depends_on:
      - ldes-postgres
  postgres:
    container_name: ldes-postgres
    image: postgres:14-alpine
    ports:
      - 5432:5432
    environment:
      - POSTGRES_PASSWORD=admin
      - POSTGRES_USER=admin
      - POSTGRES_DB=test
    networks:
      - ldes
networks:
  ldes:
    name: quick_start_network

Get error: image

The docker compose should be like:

services:
  ldes-server:
    container_name: basic_ldes-server
    image: ldes/ldes-server
    environment:
      - SPRING_CONFIG_LOCATION=/config/
    volumes:
      - ./ldes-server.yml:/config/application.yml:ro
    ports:
      - 8080:8080
    networks:
      - ldes
    depends_on:
      - ldes-postgres
  ldes-postgres:
    container_name: ldes-postgres
    image: postgres:14-alpine
    ports:
      - 5432:5432
    environment:
      - POSTGRES_PASSWORD=admin
      - POSTGRES_USER=admin
      - POSTGRES_DB=test
    networks:
      - ldes
networks:
  ldes:
    name: quick_start_network

p.s. https://github.com/Informatievlaanderen/VSDS-LDESServer4J/blob/main/docs/how-to-run.md?plain=1#L38

   url: jdbc:postgresql://localhost:5432/test

I think it should be

   url: jdbc:postgresql://ldes-postgres:5432/test

If run in docker with the docker compose demonstrated in the how-to-run Thanks

jobulcke commented 3 months ago

Resolved in https://github.com/Informatievlaanderen/VSDS-LDESServer4J/pull/1312