search

Informatievlaanderen / VSDS-LDESServer4J

Linked Data Event Streams Server for Java
https://informatievlaanderen.github.io/VSDS-LDESServer4J
European Union Public License 1.2
10 stars 11 forks source link

CollectionNotFoundException and MissingEventStreamException are almost the same #569

Closed jobulcke closed 1 year ago

jobulcke commented 1 year ago

In the package be.vlaanderen.informatievlaanderen.ldes.server.domain.exceptions are both CollectionNotFoundException and MissingEventStreamException defined, which are both used to throw when an eventstream collection cannot be found.

I suggest to drop one of the two exceptions, so that we don't have two seperate exceptions that are both thrown with the same cause

Tomvbe commented 1 year ago

Related to the more general issue on similar exceptions: https://github.com/Informatievlaanderen/VSDS-LDESServer4J/issues/661

ASDasd341 commented 1 year ago

should i look into this?