Duplicated APIs, http://localhost:8080/v1/swagger-ui/index.html

Informatievlaanderen / VSDS-LDESServer4J

Linked Data Event Streams Server for Java

https://informatievlaanderen.github.io/VSDS-LDESServer4J

European Union Public License 1.2

10 stars 9 forks source link

Duplicated APIs, http://localhost:8080/v1/swagger-ui/index.html #714

Closed xdxxxdx closed 1 year ago

xdxxxdx commented 1 year ago

Prerequisites: Start LDES Server with swagger api configured on the port 8080

On: http://localhost:8080/v1/swagger-ui/index.html

APIs :

Update DCAT metadata for a LDES
Add DCAT metadata for a LDES
Delete DCAT metadata for a LDES

appear both under Event Streams section.

and DCAT section:

I think these APIs should be only under the DCAT section?

Yalz commented 1 year ago

Hi Xueying, This is on purpose. By adding the tags "Event Streams" and "DCAT" allows a user to look for the endpoint when they're updating DCAT or when updating the event streams more easily

Tomvbe commented 1 year ago

This was intended behavior as it was not consistent between the views and eventstreams. I already made these endpoints already exclusively DCAT yesterday: https://github.com/Informatievlaanderen/VSDS-LDESServer4J/pull/694/files#diff-398e215e886483bc85b1e0c176c4976b07f3fa67c9659a70c8c8eed5440ffbba

So this is already "fixed" in develop.

Tomvbe commented 1 year ago

Closing this as it is not really an issue. The develop branch already has the desired tags. In case any other changes are desired, a github discussion could be opened.