search

Informatievlaanderen / VSDS-Linked-Data-Interactions

https://informatievlaanderen.github.io/VSDS-Linked-Data-Interactions/
European Union Public License 1.2
4 stars 7 forks source link

LdioLdesClient Handles 404 error without a crash #605

Closed xdxxxdx closed 6 months ago

xdxxxdx commented 7 months ago

ldes/ldi-orchestrator:2.5.0-SNAPSHOT

In the test, the client crashes with a 404 error with max retry reached. image

I think there should be a way to allow

  1. The client doesn't crash, as the stream can be back online. e.g. halt this pipeline instead of crash it, with a notification message saying that the stream is not available, the pipeline is paused.
  2. better logging instead of a raw crash message.

Thanks

jobulcke commented 7 months ago

As discussed with the developpers, the proposed solution of @xdxxxdx will be implemented when picking up this issue

xdxxxdx commented 6 months ago

As discussed with the developers, the proposed solution of @xdxxxdx will be implemented when picking up this issue

@jobulcke, thanks. Please also make sure there is doc regarding this "fallback" behavior. might be also worth to have a look possible https://en.wikipedia.org/wiki/List_of_HTTP_status_codes, to have a more robustic products, and integrate the test to unite testing (try out some unhappy paths).

jobulcke commented 6 months ago

Resolved in https://github.com/Informatievlaanderen/VSDS-Linked-Data-Interactions/pull/621