search

InfotelGLPI / consumables

Plugin consumables for GLPI
http://blogglpi.infotel.com
GNU General Public License v2.0
7 stars 5 forks source link

Notification of "Consumables Request Validation" template with issues in tags #14

Closed George2x closed 7 years ago

George2x commented 7 years ago

Refuse or approve materials, I received notification with empty value for ##consumablerequest.validator##, using the template Consumables Request Validation (first img). Also, only for refuse option I received the notification with the status "Waiting for approval" and must be Rejected or similar. Using the for each, it duplicates the tags with empty fields (2nd img).

approved materials rejected materials

The template is:

A continuación el resultado de aprobación de material(es):

FOREACHconsumabledatas

lang.consumablerequest.requester## : ##consumablerequest.requester

lang.consumablerequest.validator## : ##consumablerequest.validator

lang.consumablerequest.consumabletype## : ##consumablerequest.consumabletype

lang.consumablerequest.consumable## : ##consumablerequest.consumable

lang.consumablerequest.number## : ##consumablerequest.number

lang.consumablerequest.request_date## : ##consumablerequest.request_date

lang.consumablerequest.status## : ##consumablerequest.status

lang.consumable.entity## :##consumable.entity

ENDFOREACHconsumabledatas

lang.consumablerequest.comment## : ##consumablerequest.comment

amma35 commented 7 years ago

Have you tested with the version 1.2.1 plugin at first?

George2x commented 7 years ago

Not yet but I'll do right now and I'll let you know. Thanks for your help and this excellent work in the plugin.

George2x commented 7 years ago

I update to 1.2.1 the plugin and did the test, but problem continues as you could see in the screenshot attached.

image

image

amma35 commented 7 years ago

I have reproduced your bug.

Can you test by replacing the file validation.class.php (https://github.com/InfotelGLPI/consumables/blob/master/inc/validation.class.php) in glpi/plugins/consumables/inc/ ?

George2x commented 7 years ago

Thank you for the change, is almost done. I've tested and worked in the Request, Request Rejected but still is a problem with the approver in Request accepted.

image

amma35 commented 7 years ago

Can you retry the test by replacing the file again?

George2x commented 7 years ago

It works !, thank for your attention and support in the resolution.