Incorrect warranty expiration on Dell Laptop

InfotelGLPI / manufacturersimports

Plugin manufacturersimports for GLPI

http://blogglpi.infotel.com

GNU General Public License v2.0

30 stars 33 forks source link

Incorrect warranty expiration on Dell Laptop #136

Open baderarvitis opened 6 months ago

baderarvitis commented 6 months ago

Version of the plugin : 3.0.8
Version of your GLPI : GLPI 10.0.15
Steps to reproduce (which actions have you made) :

Imports warranty informations for a Dell Laptop

Expected result : Correct match for the expiration of the warranty date
Actual result : Not the correct date of the expiration warranty
URL of the page :
Screenshot of the problem (if pertinent) :

Samuel-Volant commented 5 months ago

Hello !

I had a similar problem with the start of the warranty. Not sure if it's the same for you. (probably not) One thing I found is that the "getStartDate" function from dell.class.php looked for the highest date instead of the lowest. (on Line 143) I hope it helps someone. :)

Samuel

Beufff commented 1 month ago

Hi, Have the same issue with the start date not being correct. GLPI version : 10.0.16 SuplierImport version : 3.0.8

Samuel-Volant commented 1 month ago

Hi,

I opened a Pull request to correct the issue but i'm not to familiar with github so I don't know if I did good or not. If you want to correct it yourself : In inc/dell.class.php at line 143 change if ($max_date == false || $date > $max_date) { to if ($max_date == false || $date < $max_date) {

Hope this helps !