Although there is no naming convention existing for PHP scripts that serves CSS or JS, we figured out that most of plugins are naming their files *.css.php and *.js.php. We decided to only allow scripts that are following that de facto convention in our URL filtering logic, first as it seems pretty safe, and second to keep rules as simple as possible.
I propose to rename /css/mydashboard.php to /css/mydashboard.css.php to make the plugin compatible with proposed filtering.
cedric-anne
commented
1 year ago
See https://github.com/glpi-project/glpi/pull/13197
Although there is no naming convention existing for PHP scripts that serves CSS or JS, we figured out that most of plugins are naming their files
*.css.phpand*.js.php. We decided to only allow scripts that are following that de facto convention in our URL filtering logic, first as it seems pretty safe, and second to keep rules as simple as possible.I propose to rename
/css/mydashboard.phpto/css/mydashboard.css.phpto make the plugin compatible with proposed filtering.