Budget doesn't work with Printers into 'Root Entity'

[eduardomozart]

• Version of the plugin : 1.7.1

• Version of your GLPI : 9.5.2

• Steps to reproduce (which actions have you made) :

Plug-in doesn't show printer budgets for printers located at 'Root Entity'.

• Expected result :

Budget from printers of 'Root Entity' should be calculated.

• Actual result :

The printer page cost and other informations related to "Budget" isn't calculated.

• URL of the page :

https://glpi.example.com/plugins/printercounters/front/budget.php

• Screenshot of the problem (if pertinent) :

• Solution :

The error happens because the 'Default Root' entity has ID '0'. The 'parseData' function (search.class.php) into the line 2176 compares the results with "Search::NULLVALUE", but this comparision also considerates '0' ('Default Root' ID) as a NULL value, so when glpi_plugin_printercounters_budgets.entities_id = 0, this function will set it as a null value and when the function getRecordAmount call it's sons it will fail because entities_id is null.

Changing the line 2176 from search.class.php from:

if ($val == Search::NULLVALUE) {

To:

if ($val !== 0 && $val == Search::NULLVALUE) {

fixed the problem and the entity ID from 'Default Root' entity returned as expected ('0'). I'll send a Pull Request with the bugfix above.

Here's the full debug function paths, for anyone interesting:

inc\search.class.php
   parseData

inc\budget.class.php
    formatSearchData -> getRecordsAmountForBudget -> getRecordAmount