search

Infragistics / livewire

A simple web content editor built with Electron
https://waffle.io/infragistics/livewire
19 stars 9 forks source link

Included topics use the English version #70

Closed ig-ealbert closed 8 years ago

ig-ealbert commented 8 years ago

Open (WPF) xamdiagram-configuration-overview.ja-JP.adoc in Livewire.

Observe the parts underneath "XamDiagram Configuration Summary" and "XamDiagram Configuration Summary Chart".

These parts of the topics are in English, because they are referencing another topic a la: include::xamdiagram-configuration-summary.adoc[] include::xamdiagram-configuration-summary-chart.adoc[]

They should be in Japanese.

I think this is an issue with Livewire, not Convertwire.

ig-ealbert commented 8 years ago

Is there an easy way to get the file name of the currently opened file, and if it has "ja-JP" in it, then add the same culture code to the file name of the included file? https://github.com/Infragistics/livewire/blob/master/app/modules/formats/grammar/asciidoc/include/index.js Worried that not fixing this might break all included files in the Tripwire build as well, not just the Livewire preview. If necessary, once we have the final conversion, I can do a search and add .ja-JP to all of the include:: lines. This worked in Document X, but I'm not sure exactly how it did. I think similar to the approach I recommended, where it knew which locale it was using and kept included files in that locale.

ig-ealbert commented 8 years ago

If I should log this as a convertwire issue instead (so that the include statement uses .ja-JP.adoc), let me know.

ig-ealbert commented 8 years ago

https://github.com/Infragistics/convertwire/blob/master/modules/html2AsciiDoc/converters-ig-structure.js

ig-ealbert commented 8 years ago

Decided this is a convertwire issue.