InfuseAI / piperider

Code review for data in dbt
https://www.piperider.io/
Apache License 2.0
480 stars 23 forks source link

[Chore] minor fixes to improve messages #857

Closed qrtt1 closed 1 year ago

qrtt1 commented 1 year ago

PR checklist

What type of PR is this?

chore

What this PR does / why we need it:

make errors or messages more unstandable

Which issue(s) this PR fixes:

sc-32092


Checking the picked run data

$ piperider compare-reports --base 1.json --target /Users/qrtt1/Downloads/jaffle_shop/.piperider/outputs/dev-20230817114728/run.json
Usage: piperider compare-reports [OPTIONS]
Try 'piperider compare-reports --help' for help.

Error: Invalid value for '--base': missing one of required keys: {'datasource', 'tables', 'dbt'} from: "1.json"

Show dbt-schema compatible warning

image
codecov[bot] commented 1 year ago

Codecov Report

Merging #857 (a25816b) into main (2d274b9) will decrease coverage by 0.06%. Report is 2 commits behind head on main. The diff coverage is 40.67%.

:exclamation: Current head a25816b differs from pull request most recent head a4c8855. Consider uploading reports for the commit a4c8855 to get more accurate results

@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   47.87%   47.82%   -0.06%     
==========================================
  Files          71       71              
  Lines        9944     9993      +49     
==========================================
+ Hits         4761     4779      +18     
- Misses       5183     5214      +31     
Files Changed Coverage Δ
piperider_cli/dbt/__init__.py 85.71% <0.00%> (ø)
piperider_cli/validator.py 22.14% <0.00%> (-0.77%) :arrow_down:
piperider_cli/cli.py 61.72% <39.39%> (-2.29%) :arrow_down:
piperider_cli/dbt/list_task.py 64.53% <60.00%> (+0.03%) :arrow_up:
piperider_cli/compare_report.py 30.08% <66.66%> (+0.42%) :arrow_up:
piperider_cli/utils.py 54.16% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

qrtt1 commented 1 year ago

the e2e failed has been fixed at main branch

sentry-io[bot] commented 1 year ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎