InfuseAI / piperider

Code review for data in dbt
https://www.piperider.io/
Apache License 2.0
478 stars 23 forks source link

[Chore] improve telemetry usage and run event #887

Closed popcornylu closed 11 months ago

popcornylu commented 11 months ago

In order typ

Usage event

  1. Duration: execution time in seconds
  2. Reason: ok | failed | aborted | error

Run event

  1. Duration: execution time in seconds
  2. Reason: ok | failed | aborted | error
  3. Status: true = successful
  4. Step
  5. Datasource type

Compare event(new)

  1. Duration: execution time in seconds
  2. Reason: ok | failed | aborted | error
  3. Status: true = successful
  4. Step
  5. Datasource type

PR checklist

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov[bot] commented 11 months ago

Codecov Report

Merging #887 (3ddfeaa) into main (e4c7fcb) will increase coverage by 0.12%. The diff coverage is 67.64%.

@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
+ Coverage   48.04%   48.17%   +0.12%     
==========================================
  Files          75       76       +1     
  Lines       10461    10572     +111     
==========================================
+ Hits         5026     5093      +67     
- Misses       5435     5479      +44     
Files Changed Coverage Δ
piperider_cli/recipe_executor.py 0.00% <0.00%> (ø)
piperider_cli/recipes/utils.py 29.78% <0.00%> (-0.49%) :arrow_down:
piperider_cli/cli_utils/compare_with_recipe.py 21.05% <8.33%> (-3.61%) :arrow_down:
piperider_cli/profiler/profiler.py 74.52% <33.33%> (+0.03%) :arrow_up:
piperider_cli/recipes/__init__.py 24.70% <33.33%> (-0.12%) :arrow_down:
piperider_cli/configuration.py 61.57% <64.70%> (+0.12%) :arrow_up:
piperider_cli/runner.py 52.98% <75.00%> (-1.28%) :arrow_down:
piperider_cli/event/track.py 81.48% <77.77%> (-1.86%) :arrow_down:
piperider_cli/cli_utils/run_cmd.py 83.83% <81.81%> (+3.28%) :arrow_up:
piperider_cli/event/__init__.py 79.43% <93.75%> (+1.31%) :arrow_up:
... and 1 more

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sentry-io[bot] commented 11 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎