InfuseAI / piperider

Code review for data in dbt
https://www.piperider.io/
Apache License 2.0
478 stars 23 forks source link

[Feature] sc-32292 PipeRider CLI support share to temporary quick look #889

Closed kentwelcome closed 11 months ago

kentwelcome commented 11 months ago

PR checklist

What type of PR is this? Feature

What this PR does / why we need it:

Is Login --upload --share --enable-quick-look-share Upload Behavior
❌ or ✅ Do nothing
❌ or ✅ Upload & Share to project
❌ or ✅ Upload & Share to project
❌ or ✅ Upload to project
❌ or ✅ Do nothing
❌ or ✅ Do nothing & show warning message
Do nothing & show warning message
❌ or ✅ Do nothing & show warning message
Upload to Quick Look

Which issue(s) this PR fixes: sc-32292

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov[bot] commented 11 months ago

Codecov Report

Merging #889 (7827e71) into main (48348e4) will increase coverage by 0.14%. The diff coverage is 43.01%.

@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
+ Coverage   48.16%   48.30%   +0.14%     
==========================================
  Files          76       76              
  Lines       10572    10609      +37     
==========================================
+ Hits         5092     5125      +33     
- Misses       5480     5484       +4     
Files Changed Coverage Δ
piperider_cli/compare_report.py 30.31% <0.00%> (-0.55%) :arrow_down:
piperider_cli/cloud_connector.py 14.68% <18.75%> (-0.29%) :arrow_down:
piperider_cli/cloud/__init__.py 25.78% <21.73%> (+0.05%) :arrow_up:
piperider_cli/cli_utils/compare_with_recipe.py 23.33% <33.33%> (+2.28%) :arrow_up:
piperider_cli/cli.py 67.18% <83.33%> (+1.86%) :arrow_up:
piperider_cli/cli_utils/__init__.py 95.55% <100.00%> (+4.25%) :arrow_up:
piperider_cli/cli_utils/run_cmd.py 92.39% <100.00%> (+8.55%) :arrow_up:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more