InfuseAI / piperider

Code review for data in dbt
https://www.piperider.io/
Apache License 2.0
478 stars 23 forks source link

[Bug] Escape unsupported unicode emojis for legacy windows console #908

Closed wcchang1115 closed 10 months ago

wcchang1115 commented 10 months ago

PR checklist

What type of PR is this? bug

What this PR does / why we need it:

Which issue(s) this PR fixes: sc-32406

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

codecov[bot] commented 10 months ago

Codecov Report

Merging #908 (3e4496b) into main (80655ee) will decrease coverage by 0.02%. The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   48.00%   47.98%   -0.02%     
==========================================
  Files          77       77              
  Lines       10714    10726      +12     
==========================================
+ Hits         5143     5147       +4     
- Misses       5571     5579       +8     
Files Coverage Δ
piperider_cli/validator.py 22.22% <25.00%> (+0.22%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more