InfuseAI / piperider

Code review for data in dbt
https://www.piperider.io/
Apache License 2.0
478 stars 23 forks source link

[Chore] introduce Anti-corruption Layer for yaml library #913

Closed qrtt1 closed 10 months ago

qrtt1 commented 10 months ago

PR checklist

What type of PR is this?

chore

What this PR does / why we need it:

The latest yaml library will break our code, we must make it compatible.

Which issue(s) this PR fixes:

sc-32483

codecov[bot] commented 10 months ago

Codecov Report

Merging #913 (d34758e) into main (bf71b4a) will increase coverage by 0.07%. The diff coverage is 60.67%.

@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
+ Coverage   47.94%   48.01%   +0.07%     
==========================================
  Files          77       78       +1     
  Lines       10740    10751      +11     
==========================================
+ Hits         5149     5162      +13     
+ Misses       5591     5589       -2     
Files Coverage Δ
piperider_cli/cloud/__init__.py 25.17% <ø> (-0.52%) :arrow_down:
piperider_cli/dbtutil.py 66.91% <100.00%> (-0.13%) :arrow_down:
piperider_cli/initializer.py 46.15% <100.00%> (+0.34%) :arrow_up:
piperider_cli/event/__init__.py 79.81% <83.33%> (-0.19%) :arrow_down:
piperider_cli/__init__.py 52.04% <33.33%> (+0.17%) :arrow_up:
piperider_cli/assertion_engine/assertion.py 56.93% <50.00%> (-0.09%) :arrow_down:
piperider_cli/recipes/__init__.py 23.63% <40.00%> (-0.12%) :arrow_down:
piperider_cli/configuration.py 60.34% <46.15%> (+0.12%) :arrow_up:
piperider_cli/assertion_engine/recommender.py 36.50% <16.66%> (-1.96%) :arrow_down:
piperider_cli/yaml/__init__.py 74.35% <74.35%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

qrtt1 commented 10 months ago

Our dependency requests a lower version, we won't upgrade for now.

https://github.com/dbt-labs/metricflow/commit/5b02b59ac31b727c602d835143fd5f43b8916b02