InfuseAI / piperider

Code review for data in dbt
https://www.piperider.io/
Apache License 2.0
478 stars 23 forks source link

[Feature] Connect to S3 with AWS access key and secret for duckdb #919

Closed wcchang1115 closed 10 months ago

wcchang1115 commented 10 months ago

PR checklist

What type of PR is this? feature

What this PR does / why we need it:

Which issue(s) this PR fixes: sc-32497

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

codecov[bot] commented 10 months ago

Codecov Report

Merging #919 (1622038) into main (a53e770) will increase coverage by 0.00%. The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main     #919   +/-   ##
=======================================
  Coverage   47.99%   47.99%           
=======================================
  Files          78       78           
  Lines       10756    10759    +3     
=======================================
+ Hits         5162     5164    +2     
- Misses       5594     5595    +1     
Files Coverage Δ
piperider_cli/datasource/duckdb.py 27.94% <33.33%> (+0.08%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more