search

InfuseAI / piperider

Code review for data in dbt
https://www.piperider.io/
Apache License 2.0
478 stars 23 forks source link

Incorrect ruamel import in __init__.py from v0.38.0 #923

Closed IL-William closed 9 months ago

IL-William commented 9 months ago

https://github.com/InfuseAI/piperider/blob/276a0c5138a1a715e20aea50dad86aead078f5e3/piperider_cli/yaml/__init__.py#L5

Hi there, After installing piperider for the first time, I get the following ruaml issue

Screenshot 2023-11-05 at 10 31 07

Looking at the specified file, I can see that the import is as follow

from ruamel.yaml import StreamTextType, StreamType, VersionType

This file was inserted from v0.38.0.

I can see that it is specified that ruaml should be < 0.17.40.

However, I had a look at ruamel repo using 0.17.40, and I can see it was already using from ruamel.yaml.compat

Screenshot 2023-11-05 at 10 33 38

This means that the import should be as follows

from ruamel.yaml.compat import StreamTextType, StreamType, VersionType

Alternatively, I don't know if the requested version should be downgraded to work as it is currently?

After manual modification, I can use piperider.

Screenshot 2023-11-05 at 10 35 09

In the meantime, I'll use v0.37.1 as this file was not existing yet, and there is no issue currently with it.

popcornylu commented 9 months ago

Hi @IL-William, Thanks for your feedback.

I have opened sc-32539 for internal tracking.

popcornylu commented 9 months ago

May be related to #912

popcornylu commented 9 months ago

Fixed in release v0.40.0