neighborhood999 commented 3 years ago

Screenshots

Client

Admin

Description

Fixed client & admin notebook text fields overflow

Note: Others UI fixing at primehub-console, I will create another PR.

Signed-off-by: Jie Peng im@jiepeng.me

PR checklist

[x] Ensure you have added or ran the appropriate tests for your PR.
[x] DCO signed

codecov[bot] commented 3 years ago

Codecov Report

Merging #560 (22efe92) into master (17acb55) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 22efe92 differs from pull request most recent head 4b5da0c. Consider uploading reports for the commit 4b5da0c to get more accurate results

@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   77.61%   77.61%           
=======================================
  Files           8        8           
  Lines        1626     1626           
=======================================
  Hits         1262     1262           
  Misses        364      364

Flag	Coverage Δ
unittests	`77.61% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17acb55...4b5da0c. Read the comment docs.

ggosiang commented 3 years ago

besides the username on notebook admin page and image on notebooks page, can you help to handle overflow for instanceType on notebooks page?