InfyOmLabs / laravel-generator

API and Admin Panel CRUD Generator for Laravel.
https://www.infyom.com/open-source
MIT License
3.78k stars 802 forks source link

Support for Laravel 5.4 #382

Closed gandra closed 7 years ago

gandra commented 7 years ago

Great Job! Sorry for posting here do not know for other option. You can mark it as feature eventually.

I am wondering when will be support for LAravel 5.4. Accordiong to the documentation supported laravel versions are 5.1, 5.2 & 5.3.

JeffBeltran commented 7 years ago

been on 5.4 for about 2 weeks and i have not had any problems

hkarvasonis commented 7 years ago

I used that on Laravel 5.4 and i get an error on BaseRepository about the getForeignKey() function that needs to be replaced by the getQualifiedForeignKeyName() function.

https://github.com/laravel/docs/issues/3017

reiter777 commented 7 years ago

@hkarvasonis are you still having the same problem? been working on 5.4 for 3 weeks and its ok

AlexKR commented 7 years ago

ApiTestTrait is also broken for laravel 5.4. There are changed logic for respone and removed functions like assertResponseOk

mitulgolakiya commented 7 years ago

@gandra @whereisjefe @hkarvasonis @reiter777 @AlexKR I am going to start working on laravel 5.4 support. will post the update soon.

solidevolution commented 7 years ago

What about this issue? Is there a perspective date for release supporting laravel 5.4?

We got broken unit tests after laravel update from 5.3. to 5.4..

mitulgolakiya commented 7 years ago

I have just added a support for laravel 5.4. Checkout 5.4 branch. Also, a guide is added on docs site here.

dhcmega commented 7 years ago

Hi https://github.com/InfyOmLabs/laravel-generator/blob/develop/src/Common/BaseRepository.php still needs the method to be renamed:

getForeignKey -> getQualifiedForeignKeyName

fdm-cj commented 6 years ago

LayoutPublishCommand:

$path = config('infyom.laravel_generator.path.routes', app_path('routes/web.php')); the path for laravel 5.5 should be: $path = config('infyom.laravel_generator.path.routes', 'routes/web.php');

because routes is not in the app directory anymore