search

InfyOmLabs / laravel-generator

API and Admin Panel CRUD Generator for Laravel.
https://www.infyom.com/open-source
MIT License
3.79k stars 812 forks source link

Drop Prettus as Base Repository #776

Closed xwiz closed 5 years ago

xwiz commented 5 years ago

Hi, great work with Laravel 6 compatibility. I'm an avid use of laravel-generator and I've always thought that the dependency on prettus l5 repository is needless. The Base Repository included in infyom with a few additional methods is enough as a repository. I can create a pull request using the repository class we always use in our projects. Repositories are supposed to be just data layers and Prettus is kinda twisted in the sense that instead of simply deriving from Eloquent, it uses and depends on eloquent and laravel classes making it hard to maintain

mitulgolakiya commented 5 years ago

@xwiz in Laravel Generator 6.x branch, we already dropped the support, but the old versions were using it, so we just leave that as it is. src/Common/BaseRepository.php was kept for someone if he is migrating the code from lower to 6.x. Otherwise, it's not used anywhere. We are planning to remove it very soon.

slamgundam commented 4 years ago

it is safe that i upgrade L5.8 to L6.x?

currently laravel-generator is using l5-repository as backboned

ajayinfyom commented 4 years ago

@slamgundam laravel-generator no more using l5-repository. we have created custom BaseRepository.

mitulgolakiya commented 4 years ago

@slamgundam yes, probably you can still use l5-repository for your old controllers and create new CRUD with a new based repository. Or if you are not using any complex things of l5-repository then you can update all your existing repositories to use new BaseRepository.