Ingenico-ePayments / connect-extension-magento2

Ingenico Connect based Shopping Cart Extension for Magento 2.x
https://epayments.developer-ingenico.com/documentation/ecommerce-extensions/magento-2/
MIT License
4 stars 4 forks source link

Partial Refund not available #31

Open sergiuec opened 1 year ago

sergiuec commented 1 year ago

Issue Partial refund is not available for all payment products. When a credit memo is created the quantity input for the products are not editable.

Expected Quantity must be editable and "Update qty's" button must be displayed image

Solution After analyzing the module I found out that can_refund_partial_per_invoice configuration is inserted in the wrong place. You can find the parameter under worldline_connect/general config

<worldline_connect> <model>Worldline\Connect\Model\Payment\Worldline</model> <title>Worldline Connect</title> <general> ....... <can_refund_partial_per_invoice>1</can_refund_partial_per_invoice> </general>

the correct place is under payment gateway config, in my case worlline_cards it would be payment\worldline_cards

<payment> <worldline_cards> <title>Worldline Cards</title> ......... <can_refund_partial_per_invoice>1</can_refund_partial_per_invoice> </worldline_cards>

Module Version: 3.0.2

bertterheide commented 1 year ago

@sergiuec, thank you for reporting this issue. This feature will be added In the next release.

sergiuec commented 1 year ago

@sergiuec, thank you for reporting this issue. This feature will be added In the next release.

I just discovered that the cron script which cancelled the pending orders also disappeared. In my case i just created my own cron script which does it, but I'm a little bit confused why it was dismissed as long as with hosted checkout flow it is inevitable to not have this kind of orders.

bertterheide commented 1 year ago

@sergiuec Magento has its own scheduling for deleting pending orders.

sergiuec commented 1 year ago

@sergiuec Magento has its own scheduling for deleting pending orders.

Default magento script cancels "pending_payment" orders, I've modified it to add my statuses and have different periods for worldline and other pgw's as worldline flow is sometimes unpredictable.

bertterheide commented 1 year ago

@sergiuec that sounds like a great addition to core Magento! Maybe submit a pull request there?

bertterheide commented 1 year ago

@sergiuec you could also install the following module: https://commercemarketplace.adobe.com/sparsh-magento-2-auto-cancel-order-extension.html