search

Ingenico-ePayments / connect-sdk-client-swift

Ingenico Connect iOS Swift Client SDK
https://docs.connect.worldline-solutions.com/documentation/sdk/mobile/swift/
Other
5 stars 12 forks source link

this release is obsolete for Swift 4 #1

Closed sudorobot closed 6 years ago

manhhavu commented 6 years ago

We are having trouble integrating this library in our product because it is not yet Swift 4 compatible. Have you any plan to release a Swift 4's one?

Thanks in advance,

rob-spoor commented 6 years ago

There are currently no plans to release a version specific for Swift 4. Could you please tell us what incompatibilities you have encountered?

manhhavu commented 6 years ago

Hi Rob,

The compatibility issues come mostly from the dependencies you use like CryptoSwift. These issues cause compile errors. There might be some minor issues in the Ingenico SDK itself but not many. I've created a sample repo in which you can have a look for more detail: https://github.com/manhhavu/ingenico-swift-4 (tested with XCode 9.3.1).

As you might aware, Swift 4 is the default language for new XCode versions. Any project created recently (since September 2017) is in Swift 4. It is so very important to make this library Swift4 compatible. Please consider updating the SDK.

Thanks

PatrickNLT commented 6 years ago

Any plans on updating the SDK to support Swift 4? Even after upgrading to a newer version of CryptoSwift there are still errors that make the SDK unusable in its current state.

screenshot-swift4
manhhavu commented 6 years ago

@rob-spoor : Would you accept pull request(s) for fixing the library compatibility for Swift 4 (and eventually Swift 5 which will come soon)? I'm happy to do so.

rob-spoor commented 6 years ago

We are already working on this, and we expect to be able to finalize the Swift 4 version soon.

rob-spoor commented 6 years ago

We've just released a Swift 4 compatible version. This should end up on Cocoapods soon as well.