Feature/0.2.0 - Githubissues

Ingenjorsarbete-For-Klimatet / ifk-smhi

SMHI climate data client.

https://ingenjorsarbeteforklimatet.se/ifk-smhi/

MIT License

9 stars 1 forks source link

Feature/0.2.0 #103

Closed mgcth closed 7 months ago

mgcth commented 8 months ago

Description

Work towards to 0.2.0

[x] Close #63
[x] Close #66
[x] Close #82
[x] Close #87
[x] Close #93
[x] Close #96
[x] Close #99
[x] Close #101
[x] Close #105
[x] Close #106
[x] Close #108

docNord commented 8 months ago

Are we returning pandas dfs across the board now?

mgcth commented 8 months ago

Are we returning pandas dfs across the board now?

We are returning pydantic models, which usually contain a dataframe that is validated with pandera.

mgcth commented 8 months ago

@docNord, I'm not done with the tests, but I'd like to close this and simplify the tests in another PR.

mgcth commented 7 months ago

I might have appreciated a datetime format rather than string dates (datetime.datetime.strptime(data.period["Tidsperiod (fr.o.m)"][0],"%Y-%m-%d %H:%M:%S"), but we can leave that parsing for the parent class, if needed.

Could you point to where in the code? If it is validtime from say Mesan where get_multipoint expects a string parameter, I don't think it's a good idea. Do you mean the index in the dataframes? Isn't that a date index already?

docNord commented 7 months ago

I mean in the data.period from and to fields :)

mgcth commented 7 months ago

Let's think about it, as Strang has those fields too.