search

Ingenjorsarbete-For-Klimatet / ifk-smhi

SMHI climate data client.
https://ingenjorsarbeteforklimatet.se/ifk-smhi/
MIT License
8 stars 1 forks source link

Feature/metobs parameters #92

Closed mgcth closed 5 months ago

mgcth commented 5 months ago

Description

Add support for all parameters for Metobs. Close #91.

mgcth commented 5 months ago

@docNord, could you add integration tests. Don't need one for each parameter, just the different types.

We could probably clean up the code a bit by storing the parameter type in the data class.

docNord commented 5 months ago

Alright, I will have a look and continue working in this PR. You're sure the format types are set according to your implementation in constants @mgcth ?

mgcth commented 5 months ago

I think I'm happy with this implementation, and I've updated the unit tests. Now we just need a few more integration tests.