search

Ingenjorsarbete-For-Klimatet / ifk-smhi

SMHI climate data client.
https://ingenjorsarbeteforklimatet.se/ifk-smhi/
MIT License
8 stars 1 forks source link

remove tox.ini as we no longer use flake8 #95

Closed docNord closed 8 months ago

docNord commented 8 months ago

Closes #94

Since we have moved from flake8 to ruff for linting, there's no need to set flake8-parameters.

docNord commented 8 months ago

Small thing, but still nice to get out @mgcth ...

mgcth commented 8 months ago

Sure, but can you check that ruff isn't using that file. If it is, move the contents over to pyproject.

docNord commented 8 months ago

I removed it and ran ruff without any issues locally. Shouldn't be a problem @mgcth.

mgcth commented 8 months ago

Did you try putting in a line longer than 88 characters?

docNord commented 8 months ago

There are a bunch. Black does not use the same formatting, and I have autoformat on. Plus, everything is passing, isn't it :smile

docNord commented 8 months ago

Will change in my private computer too.

On Sat, 27 Jan 2024, 20:07 Mladen Gibanica, @.***> wrote:

@.**** approved this pull request.

Ok, ruff is already using 88 as default

https://docs.astral.sh/ruff/settings/#line-length

You could try using ruff as the VS Code formatter too, if you aren't.

— Reply to this email directly, view it on GitHub https://github.com/Ingenjorsarbete-For-Klimatet/ifk-smhi/pull/95#pullrequestreview-1847199104, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7PLB5KKL4UDQ7E6QLM4KLYQVGA3AVCNFSM6AAAAABCNKL56WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBXGE4TSMJQGQ . You are receiving this because you authored the thread.Message ID: @.*** com>