Closed svartkanin closed 2 years ago
@IngoMeyer441 any chance to get this merged or is there any changes needed?
Sorry @svartkanin, I wanted to send to some change suggestions (directly as code) but was always busy with other tasks. I think your PR is useful and should be added to simple-term-menu. I have only a few things that could be changed:
explode
I would use the term raise
. @IngoMeyer441 yes I can rename it to raise
instead and also add it in a sorted way :)
Regarding the cli option, I just wanted to keep it consistent with the rest of constructor options being available. But I agree, it might not be as useful, so I can remove it
@IngoMeyer441 I've addressed all feedback and updated the PR :)
Thanks again! It is merged into develop
. I added a small notice in the README explaining your new parameter. And sorry (again) for the long waiting time...
Introducing a new option to make the menu raise an KeyboardInterrupt instead of quitting silently