search

IngoMeyer441 / simple-term-menu

A Python package which creates simple interactive menus on the command line.
MIT License
492 stars 43 forks source link

Correct skip_empty_entries behaviour when search is active #58

Closed ScoreUnder closed 2 years ago

ScoreUnder commented 2 years ago

Repro

  1. ./simple_term_menu.py hello '' world '' something else asdf jgirej boo foo --skip-empty-entries
  2. Start a search with / for the letter o
  3. Navigate all the way up and down the list to see which items are usable

Expected behaviour (PR behaviour):

No empty items are visible, so all items are selectable

Previous behaviour:

The items which now take the place of the previously-empty menu items are not selectable

IngoMeyer441 commented 2 years ago

I can confirm the bug and tested your patch. Works! Thanks again for your contribution. :smiley: