search

IngoZenz / personaldnsfilter

See http://www.zenz-solutions.de/personaldnsfilter for details
GNU General Public License v2.0
633 stars 56 forks source link

[Feature Request] Tasker integration #142

Open Valiceemo opened 3 years ago

Valiceemo commented 3 years ago

This is a great app, and my go to for local DNS filtering, but I think integration with Tasker would be a huge addition. For me personally, it's the only thing missing.

I'm no dev, but I don't believe it be a big job, and many other similar apps have Tasker integration.

For ref. Guide from the developer of Tasker

dh3lix commented 3 years ago

Copy that. Would love to see that.!

Valiceemo commented 2 years ago

Any movement on this?

IngoZenz commented 2 years ago

Not so far - but let´s keep it just open - I do not see it high prio and I haven't much time. But let´s keep it in the backlog

Rhys-T commented 1 year ago

Cross-posting some of my notes from Rethink's Tasker issue, since they may be relevant here too:

If you end up making a Tasker plugin, it would probably make sense to have it check its caller for a Rethink-specific permission or something before accepting a command. Plugins can be called by any app on the device, and obviously it would be bad if any app could just silently unblock itself by sending Rethink a 'stop' intent. Termux's Tasker plugin uses a permission for this now, as does WireGuard.

(Unfortunately, if an actual Android-style permission is used, it looks like Tasker itself - or any other automation app - would have to have its manifest modified to list that permission before it could use the plugin. Tasker's developer seems to have been willing to do this for both Termux and WireGuard, though.)

Shortcuts would need similar security considerations, though in that case a permission probably doesn't make sense because every single launcher would need to be modified to request it…

Originally posted by @Rhys-T in https://github.com/celzero/rethink-app/issues/63#issuecomment-1529179912

Valiceemo commented 5 months ago

just revisiting this, and I stumbled upon this open issue

This seems to be a similar request to mine, tasker integration / implementing intents.

The linked .apk will not install for me, Pixel 6 Pro A14. Error pop up says "App not installed as package appears to be invalid"

Already implemented in Tailscale app, and works well in my testing: r/tailscale

IngoZenz commented 5 months ago

I am not working on this topic currently and I think it won't happen soon

Valiceemo commented 5 months ago

I am not working on this topic currently and I think it won't happen soon

That's a shame. A quick Google seems to indicate there is demand for it. I'm no programmer / developer, but I have seen other apps implement intent receivers pretty quickly, with minimal effort. I think these intent receivers are quicker and more light weight than implementing the tasker plugin functions Unfortunately I am not knowledgeable enough to try to help with this.

anuraag488 commented 5 months ago

There are many users want this but don't know why it's not yet added. It's a free app and developer should only add if he wants. There is nothing wrong with this.