search

Ingwersaft / wildfly-deploy-gradle-plugin

Gradle Plugin for deploying Files to Wildfly
https://plugins.gradle.org/plugin/com.mkring.wildlydeplyplugin.deploy-wildfly-plugin
GNU General Public License v3.0
10 stars 11 forks source link

Improvement to support deploy in WildFly/JBoss domain mode #18

Closed amadeubarbosa closed 5 years ago

amadeubarbosa commented 5 years ago

Review of CLI commands and its parameters in order to support the specification of one server-group. Now there is a new 'domainServerGroup' property in FileDeployer.kt that allows specify the server-group. If empty, it'll proceed to standalone deployment as before.

Ingwersaft commented 5 years ago

Hey, thanks for your contribution! I'll take a deeper look later this week when I have more time, but a first skim looks promising.

amadeubarbosa commented 5 years ago

Should I do a rebase to your most recent master or should I create a PR to another branch? I've tested these modifications on WildFly 15 runtime but AFAIK works the same in JBoss EAP.

Ingwersaft commented 5 years ago

Sorry, was trying to get some CI up before taking a closer look into your PR and somehow closed/broke it on the way... force pushing is always a bad idea, sorry again :)

If you want I can just add your changes to master, or you can open the PR again, up to you.

amadeubarbosa commented 5 years ago

Sorry, was trying to get some CI up before taking a closer look into your PR and somehow closed/broke it on the way... force pushing is always a bad idea, sorry again :)

If you want I can just add your changes to master, or you can open the PR again, up to you.

No problem, I'll create a new PR. I just rebase my fork up to your master. I pretend keep my fork updated for further contributions ;)

Thank you!