Closed hossam-magdy closed 4 years ago
wahou, very big job !! I need some time to tests with our production product. I 'll give you a feedback as soon as possible.
@hossam-magdy Can I merge this PR ?
@touv Even though you already did 🎉 , Yes! 😄
😋 thanks for your job !
While keeping the API unchanged for the package consumers, the following changes are introduced:
eslint
+prettier
+ TS parsertravis.yml
to use defaults and node 12tsconfig.noImplicitAny: true
./bench/_bench.sh
)yarn build
, generateddist/
andnpm pack/publish
.vscode/launch.json
ready-config for debugging testsyarn build
,yarn lint
,yarn test
,yarn bench
Noticed possible further improvements… for later
options: object
, instead of multi-signature/overriding functions (major release, breaking change)stringify(parse(STRING_OF_ISSUE22))
. A test for it is already added in this PR and skipped