InjectiveLabs / cw-injective

Apache License 2.0
22 stars 24 forks source link

F/denom fix injective testing #242

Closed maxrobot closed 1 month ago

maxrobot commented 2 months ago

See changelog

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes include updates to the injective-testing package, specifically versions 1.1.1 and 1.1.2, released on August 30, 2024. These versions address issues with denominators, particularly in calculations and spot markets. Additionally, the base denomination constant in the mock setup was changed, and hardcoded strings in the exchange.rs file were replaced with constants for better maintainability.

Changes

File Change Summary
packages/injective-testing/CHANGELOG.md Updated changelog for versions 1.1.1 and 1.1.2, detailing fixes for incorrect denominators.
packages/injective-testing/Cargo.toml Updated version number from 1.1.0 to 1.1.2.
packages/injective-testing/src/mocks.rs Changed MOCK_BASE_DENOM from "ubase" to "inj".
packages/injective-testing/src/test_tube/exchange.rs Replaced hardcoded strings with constants for denominators in various functions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Exchange
    participant Mocks

    User->>Exchange: Launch Market
    Exchange->>Mocks: Use MOCK_BASE_DENOM
    Mocks-->>Exchange: Return "inj"
    Exchange->>User: Market Launched

🐇
In the meadow, changes bloom,
With "inj" now, there's more room.
Constants guide the way we play,
No more strings to lead astray.
Hops of joy, the code's refined,
In our burrow, peace of mind! 🌼


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Early access features: disabled We are currently testing the following features in early access: - **Anthropic `claude-3-5-sonnet` for code reviews**: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues on the [discussion post](https://discordapp.com/channels/1134356397673414807/1279579842131787838).