search

InjectiveLabs / docs

Injective Protocol Documentation
Apache License 2.0
16 stars 5 forks source link

Update Order Message Format to explicitly contain subaccountID #2

Closed jonathanjmak closed 4 years ago

jonathanjmak commented 4 years ago

Bug Description The current order message format is outdated, as it doesn't contain the subaccountID of the trader in the order message format.

It would also be useful to explicitly specify the full order message format for each order type (stop loss, take profit, netting) to reduce ambiguity as well.

@gorgos @bshevchenko

gorgos commented 4 years ago

@jonathanjmak I agree, that would be helpful having all message formats explicitly listed. Could you specify what exactly is outdated? https://github.com/InjectiveLabs/docs/blob/78a4a3bd88e5b8afd2ef8994bda633fb025c758e/source/includes/_derivatives_spec.md#order-message-format looks good to me.

gorgos commented 4 years ago

subaccountID is provided via takerFee == subAccountNonce. Can this be closed? @albertchon

albertchon commented 4 years ago

Yup, looks good to me. We may want to add a note about how the positionID can be determined by the marketID and subaccountID in the docs as well, to remove ambiguity.

Thanks for bringing light to this issue though @jonathanjmak!