search

InjectiveLabs / sdk-go

Tools to work with the Injective Chain, Injective EVM and EIP712.
Apache License 2.0
95 stars 41 forks source link

(feat) Added a new config option to disable the auto fix of sequence … #220

Closed aarmoa closed 5 months ago

aarmoa commented 6 months ago

This PR has been created to replace https://github.com/InjectiveLabs/sdk-go/pull/213 It implements the same changes but on top of dev branch

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

The recent updates focus on refining error handling and configuration options across several components. A notable enhancement includes the introduction of a condition to address "account sequence mismatch" errors selectively. This is complemented by a new function for building signed transactions. Additionally, the network loading function now supports a "local" configuration, enhancing flexibility.

Changes

File Path Change Summary
client/chain/chain.go Introduced conditional error handling for sequence mismatches and a new function for transaction signing.
client/common/network.go Updated LoadNetwork to support "local" configuration with specific settings.
client/common/options.go Added a boolean field to handle sequence mismatches by default in client options.

🐇✨ In the code where bytes dance, A rabbit tweaked the stance, Sequence checks, local nets, With a hop, no bug gets, In the burrow, all is chance. 🥕🌟

Recent Review Details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 73f266a8fba967ef1c19c5f235032d62fc5a6125 and 65148234579fd464cade651c36f21e53aa240f32.
Files selected for processing (3) * client/chain/chain.go (6 hunks) * client/common/network.go (1 hunks) * client/common/options.go (1 hunks)
Additional comments not posted (6)
client/common/options.go (2)
`25-25`: Added `ShouldFixSequenceMismatch` field to `ClientOptions` struct to allow configuration of sequence mismatch handling. --- `32-32`: Set default value of `ShouldFixSequenceMismatch` to `true` in `DefaultClientOptions` to ensure backward compatibility.
client/common/network.go (1)
`207-221`: Added a new case for "local" network configuration in `LoadNetwork` function, including specific endpoints and cookie assistants set to `DisabledCookieAssistant`.
client/chain/chain.go (3)
`678-678`: Ensure proper error handling for sequence mismatch. Please verify that the error message check for "account sequence mismatch" is robust and won't accidentally trigger on similar but unrelated errors. --- `744-744`: Ensure proper error handling for sequence mismatch in asynchronous broadcasts. Please verify that the error message check for "account sequence mismatch" is robust and won't accidentally trigger on similar but unrelated errors in the asynchronous broadcast method. --- `964-964`: Check for sequence mismatch in batch broadcast. Ensure that the sequence mismatch handling in `runBatchBroadcast` is consistent with other parts of the code and correctly resets the nonce.
---
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.