Closed aarmoa closed 2 months ago
[!CAUTION]
Review failed
The pull request is closed.
The recent changes enhance the flexibility and maintainability of a Cosmos SDK application by updating various workflows and configuration files. Enhancements include adopting dynamic Go version management, improving codec registrations, and refining error handling for permissions. These modifications streamline the build process, bolster testing capabilities, and enhance context management in keeper interfaces, paving the way for a more robust and adaptable application.
Files | Change Summary |
---|---|
.github/workflows/pre-commit.yml |
Added repository checkout step and dynamic Go version management; updated golangci-lint version. |
.github/workflows/run-tests.yml |
Updated actions/checkout action version and Go version management to use go.mod . |
.golangci.yml |
Introduced linter configuration, enabling various linters with specific rules. |
.pre-commit-config.yaml |
Changed pre-commit hook repository reference from a specific version to the master branch. |
Makefile |
Enhanced targets for copy-exchange-client and copy-chain-types ; cleaned up unnecessary files. |
auth_vote/authz_vote.go |
Improved initialization of the msgs variable for clarity and nil safety. |
chain/.../codec.go |
Registered new message types and updated codec initialization across various modules (auction, insurance, oracle, peggy, permissions). |
chain/.../expected_keepers.go |
Changed context parameter type from sdk.Context to context.Context in keeper interfaces, enhancing compatibility and error handling. |
chain/.../errors.go |
Introduced new error variables for improved error handling specific to the permissions module. |
chain/.../params.go |
Updated parameter handling with new fields and validation logic for admin addresses. |
chain/.../msgs.go |
Added new message types for managing Ethereum address blacklisting with validation methods. |
sequenceDiagram
participant User
participant Application
participant Codec
participant Keeper
User->>Application: Initiate action
Application->>Codec: Serialize request
Codec->>Application: Return serialized data
Application->>Keeper: Execute operation
Keeper->>Application: Return result
Application->>User: Send response
π° In fields of green and skies so blue,
A flurry of changes, fresh and new.
With codecs and keepers, all set to play,
A rabbit will hop through this bright new day!
πβ¨
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 15.77%. Comparing base (
01e7ce1
) to head (c644192
). Report is 7 commits behind head on dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR will remain a draft until the Indexer version for the chain upgrade to v1.13
Solves CHAIN-109
Summary by CodeRabbit
New Features
MsgBlacklistEthereumAddresses
,MsgRevokeEthereumBlacklist
), enhancing security capabilities.Improvements
Bug Fixes
Documentation