fix/check_tx_result_in_sync_broadcast_before_await

[aarmoa]

• Added validation in SyncBroadcast code to avoid waiting to see the TX in the mainpool if it has been rejected by the node during broadcast

Fixes CHAIN-209

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling for transaction broadcasting to ensure both errors and unsuccessful transaction responses are properly managed.

• New Features

  • Enhanced robustness of transaction processing with updated conditions for detecting transaction failures.

[coderabbitai[bot]]

Walkthrough

The pull request introduces modifications to the error handling logic in the SyncBroadcastSignedTx and broadcastTx methods of the chainClient struct in client/chain/chain.go. The updates ensure that both methods check for unsuccessful transaction responses by verifying if res.TxResponse.Code is not equal to 0, in addition to checking for errors. This enhancement aims to improve the reliability and robustness of transaction processing by better managing error detection.

Changes

File Path	Change Summary
client/chain/chain.go	Updated error handling in SyncBroadcastSignedTx and broadcastTx methods to include checks for res.TxResponse.Code not being 0, along with existing error checks. Method signatures for both methods have also been updated.

Poem

🐇 In the realm of code where transactions flow,
A tweak here and there makes the errors glow.
With checks in place, our broadcasts now sing,
Robust and reliable, oh what joy they bring!
So hop along, dear friends, let’s celebrate this feat,
For every line of code, makes our journey sweet! ✨

---

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.