Fix/sync dev after v1 53 0

[PavelInjective]

Summary by CodeRabbit

• New Features

  • Enhanced error handling for transaction broadcasting to ensure clearer feedback on transaction failures.
  • Introduction of an OFAC list for improved compliance checks.

• Bug Fixes

  • Updated transaction methods to return more accurate error responses.

• Documentation

  • Added constants and updated method names for better clarity regarding OFAC functionalities.

• Tests

  • New test suite for OFAC functionality to ensure proper address checks and compliance.
  • Retained and updated existing tests for subaccount functionalities.

[coderabbitai[bot]]

Walkthrough

The pull request introduces several modifications primarily focused on error handling in the SyncBroadcastSignedTx and broadcastTx methods of the chainClient struct. Additionally, it transitions the chain_test.go file to chain_test for testing purposes, updates the OFAC-related functionality in ofac.go, and introduces a new test suite for OFAC checks in ofac_test.go. A new JSON file, ofac.json, containing Ethereum addresses, is also added.

Changes

File	Change Summary
client/chain/chain.go	Updated error handling in SyncBroadcastSignedTx and broadcastTx methods to check res.TxResponse.Code.
client/chain/chain_test.go	Transitioned to chain_test package; modified imports and retained some tests while removing OFAC-related tests.
client/chain/ofac.go	Updated naming conventions and added new constants; modified methods to incorporate new naming.
client/chain/ofac_test.go	Introduced a new test suite for OFAC functionality with setup, teardown, and test methods.
injective_data/ofac.json	Added a new JSON file containing an array of Ethereum addresses.

Possibly related PRs

• #236: The changes in this PR add an ofacChecker to the chainClient struct, which is relevant to the modifications in the main PR that also involve error handling related to transaction broadcasting, ensuring compliance with OFAC regulations.
• #242: Similar to #236, this PR also introduces an ofacChecker and modifies the NewChainClient function to include OFAC checks, which aligns with the error handling updates in the main PR.
• #249: This PR modifies the SyncBroadcastSignedTx and broadcastTx methods, which are also the focus of the main PR, enhancing error handling during transaction broadcasting.
• #250: This PR also updates the SyncBroadcastSignedTx and broadcastTx methods, reinforcing the changes made in the main PR regarding error handling for transaction responses.
• #251: This PR modifies the ofac.go file, which is related to the OFAC functionality discussed in the main PR, ensuring that the OFAC list file path is relative, thus enhancing the overall compliance checks.

Suggested reviewers

• aarmoa

Poem

🐇 In the code where bunnies play,
Errors caught, they won't stray.
OFAC checks now stand so tall,
With tests in place, we won't fall.
Hopping through the lines so bright,
Our changes make the code just right! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.