Feat/message broadcaster

InjectiveLabs / sdk-python

Injective Exchange API for Python clients

Apache License 2.0

41 stars 27 forks source link

Feat/message broadcaster #225

Closed aarmoa closed 1 year ago

aarmoa commented 1 year ago

Implemented the MsgBroadcasterWithPk following the implementation in the TypeScript SDK.
Added two new examples showing how to use the new component (one using normal accounts and one using grantee accounts)

achilleas-kal commented 1 year ago

@aarmoa shouldn't clients receive simulation results instead of just tx results (i.e. to get order hashes or for the initial integration to find issues such as incorrect tick sizes).

aarmoa commented 1 year ago

According to the conversation with @bangjelkoski, the intention of the broadcaster is to aid users that do not want to learn the low level details of transactions broadcasting. Taking that into account, a user that has the requirements you mention should not be used the simplified approach. Also in the TS SDK the result of the simulation is not returned to the caller of the broadcast function

achilleas-kal commented 1 year ago

Okay for as long as we convey both approaches this should be fine.