Closed aarmoa closed 3 months ago
[!WARNING]
Review failed
The pull request is closed.
The changes streamline tests in tests/test_composer.py
by converting messages to dictionaries using json_format.MessageToDict
and comparing them against expected dictionary values. This approach replaces direct comparison of message attributes, enhancing test clarity and readability.
Files | Change Summary |
---|---|
tests/test_composer.py |
Refactored test methods by removing direct assertions on message attributes and adding comparisons between dictionary representations of messages and expected values for several test cases. |
In the world of code, we made a shift, Comparing dictionaries, a valuable gift.
Tests now clearer, easier to see,
For every rabbit coder, efficiency.
Attributes transformed, like magic they view,
A brighter horizon, our tests anew. 🌟🐇✨
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.60%. Comparing base (
c513f80
) to head (987f25b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary by CodeRabbit