InjectiveLabs / sdk-python

Injective Exchange API for Python clients
Apache License 2.0
41 stars 29 forks source link

feat/update_gas_estimator_base_values #344

Closed aarmoa closed 3 months ago

aarmoa commented 3 months ago

Solves CHAIN-172

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent changes improve gas limit estimation in the pyinjective trading system by increasing various gas limits for order types and optimizing test cases to utilize defined constants instead of hardcoded values. This enhances maintainability, clarity, and accuracy across the codebase and tests, ensuring alignment with the latest definitions.

Changes

Files Change Summary
pyinjective/core/gas_limit_estimator.py Increased gas limits for spot and derivative orders, modified multipliers, and adjusted constants in multiple estimator classes, indicating an overall increase.
tests/core/test_gas_limit_estimator.py, tests/core/test_message_based_transaction_fee_calculator.py Replaced hardcoded gas limit values with constants from respective estimator classes to enhance maintainability and accuracy of test cases.
CHANGELOG.md, pyproject.toml Updated version information and documented changes related to gas cost estimation and the transition to version 1.6.3.

Poem

🐰 In the land of gas limits, oh so bright,
We’ve tweaked the numbers, made them just right.
Orders and messages dance with such grace,
Constants now guide them, keeping up pace.
Hops of improvement, a joyous new day,
Let’s celebrate changes, hip-hip-hooray! 🌼✨


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.