InjectiveLabs / sdk-python

Injective Exchange API for Python clients
Apache License 2.0
41 stars 29 forks source link

Implement OFAC list address check #346

Closed PavelInjective closed 2 months ago

PavelInjective commented 2 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes introduce a compliance mechanism that checks Ethereum addresses against the Office of Foreign Assets Control (OFAC) sanctions list. A new JSON file containing sanctioned addresses is added, along with an OfacChecker class responsible for loading and verifying these addresses. Modifications are made to the codebase to incorporate checks for blacklisted addresses during authorization and broadcasting processes, enhancing regulatory compliance.

Changes

Files Change Summary
ofac.json Added a JSON file containing a list of sanctioned Ethereum addresses.
pyinjective/composer.py Introduced OfacChecker for blacklisting checks in MsgGrantGeneric and MsgGrantTyped methods.
pyinjective/core/broadcaster.py Added OfacChecker in BroadcasterAccountConfig to validate trading addresses.
pyinjective/ofac.py Implemented OfacChecker class for managing the OFAC list, including methods for downloading and checking addresses.
tests/core/test_broadcaster.py Created a unit test to verify broadcasting behavior with addresses in the OFAC list.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Composer
    participant OfacChecker
    participant Broadcaster

    User->>Composer: Request MsgGrantGeneric
    Composer->>OfacChecker: Check if granter is blacklisted
    OfacChecker-->>Composer: Return blacklist status
    alt Not Blacklisted
        Composer-->>User: Grant authorization
    else Blacklisted
        Composer-->>User: Raise exception
    end

    User->>Broadcaster: Request to broadcast message
    Broadcaster->>OfacChecker: Validate trading address
    OfacChecker-->>Broadcaster: Return blacklist status
    alt Not Blacklisted
        Broadcaster-->>User: Broadcast message
    else Blacklisted
        Broadcaster-->>User: Raise exception
    end

🐇 In the code, we now check,
For addresses that might wreck.
With OFAC's list in hand,
Compliance takes a stand.
No more sneaky trades to find,
Just safe paths for all, so kind! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
aarmoa commented 2 months ago

@PavelInjective I am reviewing now the PR. In the meantime, could you please move the ofac.json file inside pyinjective folder? (like the denoms .ini files)