coderabbitai[bot]
commented
1 month ago Walkthrough
The recent update to the project introduces OFAC (Office of Foreign Assets Control) address validations, enhancing compliance by checking restricted addresses before processing transactions. Key changes include the addition of the OfacChecker class, integration of OFAC checks in transaction methods, and updates to configuration files reflecting new trading pairs. A new JSON file stores sanctioned addresses, and tests have been added to ensure proper enforcement of these compliance measures.
Changes
| File | Change Summary |
|---|---|
| CHANGELOG.md | Added summary for version 1.7.0, highlighting OFAC validations and compliance enhancements. |
| pyinjective/composer.py | Integrated OfacChecker for address validation in MsgGrantGeneric and MsgGrantTyped methods. |
| pyinjective/core/broadcaster.py | Added OfacChecker to BroadcasterAccountConfig for checking blacklisted trading addresses during initialization. |
| pyinjective/denoms_devnet.ini | Removed multiple cryptocurrency trading pairs; added new pairs with updated parameters. |
| pyinjective/ofac.json | Introduced a JSON file containing a list of Ethereum addresses related to OFAC sanctions for compliance verification. |
| pyinjective/ofac.py | Added OfacChecker class for managing OFAC address checks, including methods for downloading and checking the blacklist. |
| pyinjective/proto/google/api/client_pb2.py | Added ExperimentalFeatures field in PythonSettings for asynchronous I/O operations. |
| pyproject.toml | Updated package version from 1.6.3 to 1.7.0. |
| tests/core/test_broadcaster.py | Created TestBroadcastAddressInOfacList to ensure compliance when broadcasting from blacklisted addresses. |
| tests/test_composer_deprecation_warnings.py | Updated market_id parameters across multiple test cases to new hexadecimal strings. |
Possibly related PRs
-
346: Implement OFAC list address check
This PR introduces the
OfacCheckerclass and theofac.jsonfile, which are directly related to the main PR's addition of validations for OFAC restricted addresses, enhancing compliance and security measures in the application.
Suggested reviewers
- @
- @aarmoa
Poem
In the garden of code, we hop and play,
With OFAC checks brightening the way.
No more blacklisted addresses near,
Compliance and safety, we hold dear.
So let’s dance and cheer, oh what a sight,
For a secure future, all feels just right! 🐇✨
socket-security[bot]
Created this PR to release all the latest changes in
devbranch tomasterfor version 1.7.0Summary by CodeRabbit
Release Notes for Version 1.7.0
New Features
Bug Fixes
Configuration Changes
Testing Enhancements