Closed KiameV closed 5 months ago
This last PR addresses some raised concerns and does one more sweep around code cleanup:
static
instead of having everything singletons
Csv___
models as I found making fields private
still works for parsing csv filesStatsUtil
to StatValueCompiler
Index
enums from tables and put it into models. Questionable whether this enum is even needed still.Going to close the PR. Feel free to make a new PR with the associated config, modifiers, and modern enum changes. Those are welcomed changes.
Blockers for the rest of the PR:
Your effort is appreciated though and has demonstrated how one may go about typing csv tables. The advantages of this system however do not outweigh the disadvantages encountered. The mod's business logic is small now but is intended to grow greatly. The csv tables are intended to be fixed and only ever rise to 10-15 tables. Typing such tables should not impact so heavily the rest of the mod's current flow or design.
Responded in discord but will summarize here: With this PR