search

Ink230 / irongoon

2 stars 1 forks source link

Starting Character HP does not match Max HP #8

Open Ink230 opened 9 months ago

Ink230 commented 9 months ago

image

Dart began with 68 HP but his active stat HP was not adjusted (at least on first start / on getting a character unlocked).

Ink230 commented 9 months ago

So with the current stale stats implementation we can get the initial visual menu value to display correctly.

The in-battle value (active stats) will remain 30/68. This can be adjusted but it will either mean the characters start with full HP or after combat they can gain the difference between their prevous maxHP and current max HP on first menu load.

Either case is not ideal.

We only want to target a fresh campaign so NewGameEvent may provide us with the means to tackle the main issue of the ticket by using the GameState52c object. However, setting values here get overwritten at a later date.

Ink230 commented 9 months ago

NewGameEvent gives us gameState_800babc while in title mode

interacting with this is useless since existing values of gameState_800babc from title mode are never accounted for in future modes, and are only overwritten from this point on

ex: NewGame.setUpNewGameData() is called after NewGameEvent is posted?

Ink230 commented 9 months ago

NewGameDataEvent is needed or check if SC is refactoring how setUpNewGameData is used / implemented.