Inklings-io / selfauth

self-hosted auth_endpoint using simple login mechanism
Creative Commons Zero v1.0 Universal
81 stars 15 forks source link

Strict verification for client provided parameters #13

Closed Zegnat closed 7 years ago

Zegnat commented 7 years ago

I am working on this, but documenting here.

Allowed character ranges for state and scope taken from RFC 6749: OAuth 2.0.

When state or scope are given as empty strings, should that be treated as omitted? Should it throw an error?

For the “full URI” requirement we should use a PHP Validate filter: FILTER_VALIDATE_URL. I think we enable both FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED to force the “full” part of the requirement.

Zegnat commented 7 years ago

This landed through https://github.com/Inklings-io/selfauth/commit/2b8bc0edc6f5ccbcfb819434c9791e189505b536.