search

Inklings-io / selfauth

self-hosted auth_endpoint using simple login mechanism
Creative Commons Zero v1.0 Universal
81 stars 15 forks source link

Do not ship with config.php #7

Closed sebsel closed 7 years ago

sebsel commented 7 years ago

The shared host I tested on has a strong opcache, and since config.php is a php file, it caches it.

Maybe check if it exists, if not, create. And add "create a file named config.php" to the instructions.

Also, at this moment, @dissolve committed some test-values (by accident?), so when it knows how to handle a non-existing config.php, you can .gitignore it. https://github.com/Inklings-io/selfauth/commit/b9e4008fc490c08f3739a29370e08e955d41322d#diff-9e5e2527d69c009a81b8ecd730f3957e

sebsel commented 7 years ago

I now saw that it's already in the .gitignore, but hasn't been deleted from the repo yet.

Still: we need to teach setup.php what to do when there's no config.php.

At this point, we check with is_writeable() here, but that one "Returns TRUE if the filename exists and is writable.", so that's not a good check.

dissolve commented 7 years ago

closing this issue, as we no longer include config.php in the repo