Inlyne-Project / inlyne

Introducing Inlyne, a GPU powered yet browserless tool to help you quickly view markdown files in the blink of an eye.
MIT License
1.08k stars 26 forks source link

All images appear dim and distorted #160

Open CosmicHorrorDev opened 1 year ago

CosmicHorrorDev commented 1 year ago

in my case not only fonts, even images appear with wrong contrast and different colors than should be:

1694176554

1694176810

Above is inlyne, below is normal image opened with firefox

Any idea why this happens?

Originally posted by @felixsanz in https://github.com/trimental/inlyne/issues/102#issuecomment-1711603812

CosmicHorrorDev commented 1 year ago

@felixsanz Can you share any of the pictures where you notice this and I can try to reproduce? It could either be the image file causing issues, or something specific to your computer

felixsanz commented 1 year ago

@felixsanz Can you share any of the pictures where you notice this and I can try to reproduce? It could either be the image file causing issues, or something specific to your computer

In happens with all pictures!

Example: wikipedia's photo of katy perry

1694204111

The warnings and that stuff appear even when no image. I don't know if related.

1694204247

And i don't think it's my system. All browsers (firefox, chrome, brave...), vscode, imv (image viewer), gimp, etc etc. all are fine! It's just inlyne.

And yes, in images this contrast issue is seen easily, but the font rendering also has contrast issues.

I don't know how can I help to debug it, but happy to help.

CosmicHorrorDev commented 1 year ago

The font issue may be improved by running off the current main since there have been quite a few unreleased changes related to fonts

I'm not sure where the issue lies for images however. If you could run the test suite for the project there are some tests checking some of the image related logic. There's got to be some device specific quirk that's not getting handled right. I haven't seen any similar reports

felixsanz commented 1 year ago
running 25 tests
test keybindings::tests::sanity ... ok
test image::tests::source_image_variety ... ok
test opts::tests::error_msg::unknown_theme ... ok
test opts::tests::error_msg::invalid_theme_ty ... ok
test opts::tests::parse::debug_assert ... ok
test opts::tests::parse::builtin_syntax_theme ... ok
test opts::tests::parse::defaults ... ok
test opts::tests::parse::missing_file_arg ... ok
test opts::tests::parse::custom_syntax_theme ... ok
test opts::tests::parse::cli_kitchen_sink ... ok
test utils::tests::md_to_html ... ok
test interpreter::tests::centered_image_with_size_align_and_link ... ok
test interpreter::tests::bare_link_gets_autolinked ... ok
test opts::config::tests::defaults_file_is_in_sync ... ok
test interpreter::tests::checklist_has_no_text_prefix ... ok
test interpreter::tests::footnotes_list_prefix ... ok
test interpreter::tests::toml_gets_highlighted ... ok
test interpreter::tests::ordered_list_in_unordered ... ok
test interpreter::tests::nested_ordered_list ... ok
test interpreter::tests::unordered_list_in_ordered ... ok
test opts::tests::parse::from_cli ... ok
test interpreter::tests::code_block_bg_color ... ok
test opts::tests::parse::config_overrides_default ... ok
test interpreter::tests::handles_comma_in_info_str ... ok
test watcher::tests::the_gauntlet ... ok

test result: ok. 25 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.86s

i'm using wayland. it could be the issue? i don't think so but...

CosmicHorrorDev commented 1 year ago

Well that means decoding isn't the issue at least. What distro are you using? I can setup a VM to see if it's something with the distro, or if it's hardware or setup specific

felixsanz commented 1 year ago

i'm using arch linux