Error when collecting resources from new accounts

Innablr / revolver

AWS Powercycle Facility

MIT License

2 stars 2 forks source link

Error when collecting resources from new accounts #341

Closed lyricnz closed 1 month ago

lyricnz commented 1 month ago

While this could possibly be caused by client-specific controls etc, the actual error appears to be related to attempting to collect Tags from undefined resources (no idea yet how that happens). This may be related to https://github.com/Innablr/revolver/pull/324

lyricnz commented 1 month ago

With development webpack, and a kludge to work around the direct symptom

The stack trace is

lyricnz commented 1 month ago

Caused by https://github.com/Innablr/revolver/commit/38403620b3ccfa5738bc267f7e95d6bae2a3de09#diff-763de440cb8d05e2f222871c41b804f176b0b37debe28c091459e16cd7c8f0b9L231

This change didn't create the InstrumentedEc2 and instead passed the native AWS resource. Will PR a fix now.

lyricnz commented 1 month ago

Closing. Was 100% a bug as identified above.