search

InnerSourceCommons / InnerSourceLearningPath

Holds the source material for the InnerSource Commons Learning Path
https://innersourcecommons.org/learningpath
Creative Commons Attribution Share Alike 4.0 International
74 stars 46 forks source link

Pulling contributors in as reviewers #292

Open MaineC opened 4 years ago

MaineC commented 4 years ago

In the learning path for the Trusted Committer (part 2) we explain how it's the trusted committers that are reviewing code. In a first approximation this is correct and matches what I see in many open source projects.

When it comes to recruiting new committers and onboarding them I have seen a different approach:

https://blogs.apache.org/comdev/entry/an-approach-to-community-building (pretty much at the bottom) - contributors at Apache Beam are encouraged to do code reviews as well - in particular if the original patch comes from a committer, the idea is that such a review is enough for merging the code.

Maybe this is something for an InnerSource Pattern instead of the LearningPath though.

rrrutledge commented 4 years ago

Hi, @MaineC, thanks for this comment. You're interested in seeing a #learning-path segment on this topic?

MaineC commented 4 years ago

I don't know what the solution to this looks like. Maybe it really is just another pattern for the Patterns project and not an entire learning path segment.

It is just something that I noticed going through the translation of the Trusted Committer part and needed a place to put the thought that was not my good old paper notebook that's only visible to me.

rrrutledge commented 4 years ago

I feel like it fits squarely as part of this learning path segment.