search

InnerSourceCommons / InnerSourceLearningPath

Holds the source material for the InnerSource Commons Learning Path
https://innersourcecommons.org/learningpath
Creative Commons Attribution Share Alike 4.0 International
74 stars 46 forks source link

375-static-workbook-images #524

Closed marshmallowrobot closed 1 year ago

marshmallowrobot commented 1 year ago

It's all new! and improved! haha

This PR includes an HTML image template, new static images, and a small change to section data JSON to get them included during site generation.

Please let me know your feedbacks! TY!

(This PR is tangentially related to a previously closed PR: https://github.com/InnerSourceCommons/InnerSourceLearningPath/pull/522)

rrrutledge commented 1 year ago

Woah! Very excited to look at this!

marshmallowrobot commented 1 year ago

@rrrutledge and I walked through this PR together after today's Learning Path Meeting. We decided to favor consistency regarding the treatment of the images, at least for now.

Like the other static images, the workbook images should live only in the website repository (innersourcecommons.org). They should not live in both repos and get copied from one to the other.

I will update this PR to remove the static images and submit a sister PR in the other repository.

marshmallowrobot commented 1 year ago

The sister-PR in innersourcecommons.org repository is ready for review! https://github.com/InnerSourceCommons/innersourcecommons.org/pull/461

This PR is also ready for a second review!

rrrutledge commented 1 year ago

Thanks for these updates, @marshmallowrobot ❗️I’m excited to take a look.

rrrutledge commented 1 year ago

Looks like the companion PR is in. Let's do this.